feat: #1448 add missing ChoiceChip properties #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add surfaceTintColor, clipBehavior, and checkmarkColor properties from Flutter's ChoiceChip widget
ahmedmandur
force-pushed
the
feature/add-missing-choicechip-properties
branch
from
3ea2a2e to
bae4075
Compare
|
Hi, thanks for contribution! |
Add additional properties from Flutter's ChoiceChip widget: - autofocus - avatarBoxConstraints - chipAnimationStyle - color - iconTheme - tooltip Update documentation in both code and README Fixes flutter-form-builder-ecosystem#1448
|
i made the changes and added the mentioned properties. |
deandreamatias
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 21 21
Lines 774 774
=======================================
Hits 682 682
Misses 92 92 ☔ View full report in Codecov by Sentry. |
deandreamatias
merged commit 1c9acc8
into
flutter-form-builder-ecosystem:main
6 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all missing properties from Flutter's ChoiceChip widget to FormBuilderChoiceChip to enhance customization options and match Flutter's native widget capabilities.
Connection with issue(s)
Connected to #1448
Solution description
Added the following properties from Flutter's ChoiceChip widget to FormBuilderChoiceChip:
Core properties:
surfaceTintColor: For Material 3 surface tint color supportclipBehavior: For controlling how the chip clips its contentcheckmarkColor: For customizing the checkmark color when selectedautofocus: Control initial focus stateavatarBoxConstraints: Control avatar size and constraintschipAnimationStyle: Customize selection animation stylecolor: State-based color customizationiconTheme: Icon styling customizationtooltip: Long-press tooltip supportAll properties were added with their original documentation and default values to maintain consistency with Flutter's implementation.
Screenshots or Videos
N/A - The changes are property additions that enhance customization options without visual changes to the default appearance.
To Do